Fixes #10344 #10345
Merged
Fixes #10344 #10345
+125
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
reviewed
Apr 18, 2024
| @@ -558,7 +558,7 @@ function emojiTag(tag) { | |||
| emojiText += ""; | |||
| } | |||
|
|
|||
| if (tag.includes("x86") || tag.includes("_64") || tag.includes("amd64")) { | |||
| if (tag.includes("x86") || tag.includes("x64") || tag.includes("_64") || tag.includes("amd64")) { | |||
There was a problem hiding this comment.
why has _64 been a part of this check? that is a very dubious way to check for x86_64.
paperdave
reviewed
Apr 18, 2024
src/cli/build_command.zig
Outdated
| .linux => "'linux'", | ||
| .mac => "'darwin'", | ||
| .windows => "'win32'", | ||
| else => "unknown", |
There was a problem hiding this comment.
could consider just using Environment.os.nameString() to avoid repeating yourself here. then surround it with quotes
paperdave
reviewed
Apr 18, 2024
src/cli/build_command.zig
Outdated
| .windows => "'win32'", | ||
| else => "unknown", | ||
| }, | ||
| switch (Environment.isX64) { |
There was a problem hiding this comment.
this switch looks weird. i would've just used switch (builtin.target.cpu.arch)
make the else a compile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10344
How did you verify your code works?
Test